Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new module: samtools/consensus #6064

Merged
merged 11 commits into from
Jul 31, 2024
Merged

Add new module: samtools/consensus #6064

merged 11 commits into from
Jul 31, 2024

Conversation

LilyAnderssonLee
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@LilyAnderssonLee LilyAnderssonLee requested a review from a team as a code owner July 30, 2024 11:19
@LilyAnderssonLee LilyAnderssonLee requested review from leoisl and removed request for a team July 30, 2024 11:19
SPPearce
SPPearce reviewed Jul 31, 2024
View reviewed changes
modules/nf-core/samtools/consensus/main.nf Outdated Show resolved Hide resolved
modules/nf-core/samtools/consensus/main.nf Outdated Show resolved Hide resolved
modules/nf-core/samtools/consensus/main.nf Outdated Show resolved Hide resolved
modules/nf-core/samtools/consensus/main.nf Outdated Show resolved Hide resolved
@SPPearce
Copy link
Contributor

Once you regenerate the tests without the _consensus I think we are ready to go.

@LilyAnderssonLee
Copy link
Contributor Author

Thank you again for your comments and reviews!!!

@LilyAnderssonLee LilyAnderssonLee added this pull request to the merge queue Jul 31, 2024
Merged via the queue into nf-core:master with commit 4133cae Jul 31, 2024
12 checks passed
@LilyAnderssonLee LilyAnderssonLee deleted the samtools_consensus branch July 31, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPPearce SPPearce SPPearce approved these changes

@leoisl leoisl Awaiting requested review from leoisl leoisl was automatically assigned from nf-core/nf-test

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LilyAnderssonLee @SPPearce